GithubFollow/One-KVM
1
0
Fork 0
mirror of https://github.com/mofeng-git/One-KVM.git synced 2025-12-13 01:30:31 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix crash on unload (#136)

Browse Source 
* Fix crash on unload

Within main, exists a `window.beforeunload` handler which brings up the "Are you sure you want to close PiKVM session?" message.   When the page is refreshed, the event is `undefined` and, the code which sets the `event.returnValue` to the aforementioned text provides an exception.  

To reproduce:
1. Open KVMD web
2. Open developer tools to view Console.
3. Interact with the page by clicking the main window.
4. Refresh the page
5. Observe type error in console. 

This patch checks if the event is defined before attempting to set the `event.returnValue`.  Other functions are maintained.

* Add space
This commit is contained in:
Adam Outler 2023-05-27 11:08:57 -04:00 committed by GitHub
parent f0a860600d
commit bfbf3172e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/share/js/kvm/main.js
View File

@ -36,7 +36,9 @@ export function main() {
if (value) {
window.onbeforeunload = function(event) {
let text = "Are you sure you want to close PiKVM session?";
event.returnValue = text;
if (event) {
event.returnValue = text;
}
return text;
};
} else {