hid with granularity prototype

kvmd/apps/vnc/server.py

@@ -189,7 +189,11 @@ class _Client(RfbClient):  # pylint: disable=too-many-instance-attributes
                         self.__shared_params.name = name
 
         elif event_type == "hid_state":
-            if self._encodings.has_leds_state:
+            if (
+                self._encodings.has_leds_state
+                and ("keyboard" in event)
+                and ("leds" in event["keyboard"])
+            ):
                 await self._send_leds_state(**event["keyboard"]["leds"])
 
     # =====

kvmd/plugins/hid/__init__.py

@@ -101,6 +101,19 @@ class BaseHid(BasePlugin):  # pylint: disable=too-many-instance-attributes
         raise NotImplementedError
 
     async def poll_state(self) -> AsyncGenerator[dict, None]:
+        # ==== Granularity table ====
+        #   - enabled   -- Full
+        #   - online    -- Partial
+        #   - busy      -- Partial
+        #   - connected -- Partial, nullable
+        #   - keyboard.online  -- Partial
+        #   - keyboard.outputs -- Partial
+        #   - keyboard.leds    -- Partial
+        #   - mouse.online     -- Partial
+        #   - mouse.outputs    -- Partial, follows with absolute
+        #   - mouse.absolute   -- Partial, follows with outputs
+        # ===========================
+
         yield {}
         raise NotImplementedError
 

kvmd/plugins/hid/_mcu/__init__.py

@@ -217,6 +217,7 @@ class BaseMcuHid(BaseHid, multiprocessing.Process):  # pylint: disable=too-many-
                 mouse_outputs["active"] = active_mouse
 
         return {
+            "enabled": True,
             "online": online,
             "busy": bool(state["busy"]),
             "connected": (bool(outputs2 & 0b01000000) if outputs2 & 0b10000000 else None),

kvmd/plugins/hid/bt/__init__.py

@@ -141,6 +141,7 @@ class Plugin(BaseHid):  # pylint: disable=too-many-instance-attributes
         state = await self.__server.get_state()
         outputs: dict = {"available": [], "active": ""}
         return {
+            "enabled": True,
             "online": True,
             "busy": False,
             "connected": None,

kvmd/plugins/hid/ch9329/__init__.py

@@ -104,6 +104,7 @@ class Plugin(BaseHid, multiprocessing.Process):  # pylint: disable=too-many-inst
         absolute = self.__mouse.is_absolute()
         leds = await self.__keyboard.get_leds()
         return {
+            "enabled": True,
             "online": state["online"],
             "busy": False,
             "connected": None,

kvmd/plugins/hid/otg/__init__.py

@@ -134,6 +134,7 @@ class Plugin(BaseHid):  # pylint: disable=too-many-instance-attributes
         keyboard_state = await self.__keyboard_proc.get_state()
         mouse_state = await self.__mouse_current.get_state()
         return {
+            "enabled": True,
             "online": True,
             "busy": False,
             "connected": None,

web/kvm/index.html

@@ -256,7 +256,6 @@
             <button class="row33" data-force-hide-menu id="stream-screenshot-button">&bull; Screenshot</button>
             <button class="row33" id="stream-reset-button">Reset stream</button>
           </div>
-          <div class="feature-disabled" id="hid-outputs">
           <hr>
           <table class="kv">
             <tr class="feature-disabled" id="hid-outputs-keyboard">
@@ -272,7 +271,6 @@
               </td>
             </tr>
           </table>
-          </div>
           <details>
             <summary>Keyboard &amp; Mouse (HID) settings</summary>
             <div class="spoiler">

web/kvm/navbar-system.pug

@@ -71,7 +71,6 @@ li(id="system-dropdown" class="right")
 			button(data-force-hide-menu data-show-window="stream-window" class="row33") • Show stream
 			button(data-force-hide-menu id="stream-screenshot-button" class="row33") • Screenshot
 			button(id="stream-reset-button" class="row33") Reset stream
-		div(id="hid-outputs" class="feature-disabled")
 		hr
 		table(class="kv")
 			tr(id="hid-outputs-keyboard", class="feature-disabled")

web/share/js/kvm/hid.js

@@ -35,6 +35,7 @@ export function Hid(__getGeometry, __recorder) {
 
 	/************************************************************************/
 
+	var __state = null;
 	var __keyboard = null;
 	var __mouse = null;
 
@@ -102,8 +103,6 @@ export function Hid(__getGeometry, __recorder) {
 	/************************************************************************/
 
 	self.setSocket = function(ws) {
-		tools.el.setEnabled($("hid-reset-button"), ws);
-		tools.el.setEnabled($("hid-jiggler-switch"), ws);
 		if (!ws) {
 			self.setState(null);
 		}
@@ -112,78 +111,135 @@ export function Hid(__getGeometry, __recorder) {
 	};
 
 	self.setState = function(state) {
-		let has_relative_squash = false;
-
 		if (state) {
-			tools.feature.setEnabled($("hid-jiggler"), state.jiggler.enabled);
+			if (!__state) {
-			$("hid-jiggler-switch").checked = state.jiggler.active;
+				__state = {"keyboard": {}, "mouse": {}};
 			}
-		if (state && state.online) {
+			if (state.enabled !== undefined) {
-			let keyboard_outputs = state.keyboard.outputs.available;
+				__state.enabled = state.enabled; // Currently unused, always true
-			let mouse_outputs = state.mouse.outputs.available;
+			}
-			if (keyboard_outputs.length) {
+			if (__state.enabled !== undefined) {
-				if ($("hid-outputs-keyboard-box").outputs !== keyboard_outputs) {
+				for (let key of ["online", "busy", "connected", "jiggler"]) {
+					if (state[key] !== undefined) {
+						__state[key] = state[key];
+					}
+				}
+				for (let hid of ["keyboard", "mouse"]) {
+					if (state[hid] === undefined) {
+						state[hid] = {}; // Add some stubs for processing
+					}
+					for (let key of ["online", "outputs", (hid === "keyboard" ? "leds" : "absolute")]) {
+						__state[hid][key] = state[hid][key];
+					}
+				}
+				if (state.connected !== undefined) {
+					tools.feature.setEnabled($("hid-connect"), (__state.connected !== null));
+					$("hid-connect-switch").checked = !!__state.connected;
+				}
+				if (state.jiggler !== undefined) {
+					tools.feature.setEnabled($("hid-jiggler"), __state.jiggler.enabled);
+					$("hid-jiggler-switch").checked = __state.jiggler.active;
+				}
+				if (state.keyboard.outputs !== undefined) {
+					__updateKeyboardOutputs(__state.keyboard.outputs);
+				}
+				if (state.mouse.outputs !== undefined) {
+					__updateMouseOutputs(__state.mouse.outputs, __state.mouse.absolute); // Follows together
+				}
+				if (
+					state.keyboard.online !== undefined || state.keyboard.leds !== undefined
+					|| state.online !== undefined || state.busy !== undefined
+				) {
+					__keyboard.setState(__state.keyboard.online, __state.keyboard.leds, __state.online, __state.busy);
+				}
+				if (
+					state.mouse.online !== undefined || state.mouse.absolute !== undefined
+					|| state.online !== undefined || state.busy !== undefined
+				) {
+					__mouse.setState(__state.mouse.online, __state.mouse.absolute, __state.online, __state.busy);
+				}
+				if (state.online !== undefined || state.busy !== undefined) {
+					tools.radio.setEnabled("hid-outputs-keyboard-radio", (__state.online && !__state.busy));
+					tools.radio.setEnabled("hid-outputs-mouse-radio", (__state.online && !__state.busy));
+					tools.el.setEnabled($("hid-connect-switch"), (__state.online && !__state.busy));
+				}
+			}
+		} else {
+			__state = null;
+			tools.radio.setEnabled("hid-outputs-keyboard-radio", false);
+			tools.radio.setEnabled("hid-outputs-mouse-radio", false);
+			tools.el.setEnabled($("hid-connect-switch"), false);
+			tools.el.setEnabled($("hid-mouse-squash-switch"), false);
+			tools.el.setEnabled($("hid-mouse-sens-slider"), false);
+		}
+		tools.el.setEnabled($("hid-reset-button"), __state);
+		tools.el.setEnabled($("hid-jiggler-switch"), __state);
+	};
+
+	var __updateKeyboardOutputs = function(outputs) {
+		let avail = outputs.available;
+		if (avail.length > 0) {
+			let el = $("hid-outputs-keyboard-box");
+			let avail_json = JSON.stringify(avail);
+			if (el.__avail_json !== avail_json) {
 				let html = "";
-					for (let args of [
+				for (let pair of [
 					["USB",  "usb"],
 					["PS/2", "ps2"],
 					["Off",  "disabled"],
 				]) {
-						if (keyboard_outputs.includes(args[1])) {
+					if (avail.includes(pair[1])) {
-							html += tools.radio.makeItem("hid-outputs-keyboard-radio", args[0], args[1]);
+						html += tools.radio.makeItem("hid-outputs-keyboard-radio", pair[0], pair[1]);
 					}
 				}
-					$("hid-outputs-keyboard-box").innerHTML = html;
+				el.innerHTML = html;
-					$("hid-outputs-keyboard-box").outputs = keyboard_outputs;
 				tools.radio.setOnClick("hid-outputs-keyboard-radio", () => __clickOutputsRadio("keyboard"));
+				el.__avail_json = avail_json;
 			}
-				tools.radio.setValue("hid-outputs-keyboard-radio", state.keyboard.outputs.active);
+			tools.radio.setValue("hid-outputs-keyboard-radio", outputs.active);
 		}
-			let has_relative = false;
+		tools.feature.setEnabled($("hid-outputs-keyboard"), (avail.length > 0));
-			if (mouse_outputs.length) {
+	};
-				if ($("hid-outputs-mouse-box").outputs !== mouse_outputs) {
+
+	var __updateMouseOutputs = function(outputs, absolute) {
+		let has_relative = null;
+		let has_relative_squash = null;
+		let avail = outputs.available;
+		if (avail.length > 0) {
+			let el = $("hid-outputs-mouse-box");
+			let avail_json = JSON.stringify(avail);
+			if (el.__avail_json !== avail_json) {
+				has_relative = false;
 				let html = "";
-					for (let args of [
+				for (let pair of [
 					["Absolute",  "usb",       false],
 					["Abs-Win98", "usb_win98", false],
 					["Relative",  "usb_rel",   true],
 					["PS/2",      "ps2",       true],
-						["Off", "disabled"],
+					["Off",       "disabled",  false],
 				]) {
-						if (mouse_outputs.includes(args[1])) {
+					if (avail.includes(pair[1])) {
-							html += tools.radio.makeItem("hid-outputs-mouse-radio", args[0], args[1]);
+						html += tools.radio.makeItem("hid-outputs-mouse-radio", pair[0], pair[1]);
-							has_relative = (has_relative || args[2]);
+						has_relative = (has_relative || pair[2]);
 					}
 				}
-					$("hid-outputs-mouse-box").innerHTML = html;
+				el.innerHTML = html;
-					$("hid-outputs-mouse-box").outputs = mouse_outputs;
 				tools.radio.setOnClick("hid-outputs-mouse-radio", () => __clickOutputsRadio("mouse"));
+				el.__avail_json = avail_json;
 			}
-				tools.radio.setValue("hid-outputs-mouse-radio", state.mouse.outputs.active);
+			tools.radio.setValue("hid-outputs-mouse-radio", outputs.active);
-				has_relative_squash = ["usb_rel", "ps2"].includes(state.mouse.outputs.active);
+			has_relative_squash = (["usb_rel", "ps2"].includes(outputs.active));
 		} else {
-				has_relative = !state.mouse.absolute;
+			has_relative = !absolute;
 			has_relative_squash = has_relative;
 		}
-			tools.feature.setEnabled($("hid-outputs"), (keyboard_outputs.length || mouse_outputs.length));
+		if (has_relative !== null) {
-			tools.feature.setEnabled($("hid-outputs-keyboard"), keyboard_outputs.length);
-			tools.feature.setEnabled($("hid-outputs-mouse"), mouse_outputs.length);
 			tools.feature.setEnabled($("hid-mouse-squash"), has_relative);
 			tools.feature.setEnabled($("hid-mouse-sens"), has_relative);
-			tools.feature.setEnabled($("hid-connect"), (state.connected !== null));
-			$("hid-connect-switch").checked = !!state.connected;
-		}
-
-		tools.radio.setEnabled("hid-outputs-keyboard-radio", (state && state.online && !state.busy));
-		tools.radio.setEnabled("hid-outputs-mouse-radio", (state && state.online && !state.busy));
-		tools.el.setEnabled($("hid-mouse-squash-switch"), (has_relative_squash && !state.busy));
-		tools.el.setEnabled($("hid-mouse-sens-slider"), (has_relative_squash && !state.busy));
-		tools.el.setEnabled($("hid-connect-switch"), (state && state.online && !state.busy));
-
-		if (state) {
-			__keyboard.setState(state.keyboard.online, state.keyboard.leds, state.online, state.busy);
-			__mouse.setState(state.mouse.online, state.mouse.absolute, state.online, state.busy);
 		}
+		tools.feature.setEnabled($("hid-outputs-mouse"), (avail.length > 0));
+		tools.el.setEnabled($("hid-mouse-squash-switch"), has_relative_squash);
+		tools.el.setEnabled($("hid-mouse-sens-slider"), has_relative_squash);
 	};
 
 	var __releaseAll = function() {