From 0ca236dbb4987f6bb527c0b8740d4b76b6f411fd Mon Sep 17 00:00:00 2001
From: SukkaW <isukkaw@gmail.com>
Date: Sun, 6 Oct 2024 08:01:10 +0800
Subject: [PATCH] Whitelist Crashlytics Domains

---
 Build/build-cdn-download-conf.ts      |  4 ++
 Build/constants/reject-data-source.ts | 62 +++++++++++++++++++++++++++
 Source/domainset/cdn.conf             | 28 ------------
 3 files changed, 66 insertions(+), 28 deletions(-)

diff --git a/Build/build-cdn-download-conf.ts b/Build/build-cdn-download-conf.ts
index c7739821..c3d988d7 100644
--- a/Build/build-cdn-download-conf.ts
+++ b/Build/build-cdn-download-conf.ts
@@ -8,6 +8,7 @@ import { appendArrayInPlace } from './lib/append-array-in-place';
 import { SOURCE_DIR } from './constants/dir';
 import { processLine } from './lib/process-line';
 import { DomainsetOutput } from './lib/create-file';
+import { CRASHLYTICS_WHITELIST } from './constants/reject-data-source';
 
 const getS3OSSDomainsPromise = (async (): Promise<string[]> => {
   const trie = createTrie((await getPublicSuffixListTextPromise()).reduce<string[]>(
@@ -70,6 +71,9 @@ export const buildCdnDownloadConf = task(require.main === module, __filename)(as
   appendArrayInPlace(downloadDomainSet, S3OSSDomains.map(domain => `.${domain}`));
   appendArrayInPlace(downloadDomainSet, steamDomainSet);
 
+  // we have whitelisted the crashlytics domain, but it doesn't mean we can't put it in CDN policy
+  appendArrayInPlace(cdnDomainsList, CRASHLYTICS_WHITELIST);
+
   return Promise.all([
     new DomainsetOutput(span, 'cdn')
       .withTitle('Sukka\'s Ruleset - CDN Domains')
diff --git a/Build/constants/reject-data-source.ts b/Build/constants/reject-data-source.ts
index 170eb480..abbb9171 100644
--- a/Build/constants/reject-data-source.ts
+++ b/Build/constants/reject-data-source.ts
@@ -282,7 +282,69 @@ export const ADGUARD_FILTERS_EXTRA: AdGuardFilterSource[] = [
   ]
 ];
 
+// In a hostile network like when an ad blocker is present, apps might be crashing, and these errors need to be
+// The reason for unblocking crashlytics is to not make developers life worse by breaking crash reporting.
+// In a hostile network like when an ad blocker is present, apps might be crashing, and these errors need to be
+// reported to devs, otherwise they won't learn about the issue and won't fix it.
+// Also, it is not a common third-party analytics tracker, Crashlytics is not used for collecting users' data.
+export const CRASHLYTICS_WHITELIST = [
+  // VSCode Telemetry, see https://sts.online.visualstudio.com/api/swagger/index.html
+  'sts.online.visualstudio.com',
+  // Sentry
+  '.ingest.sentry.io',
+  // bugsnag
+  '.sessions.bugsnag.com',
+  '.notify.bugsnag.com',
+  // influxdata
+  '.cloud.influxdata.com',
+  '.cloud1.influxdata.com',
+  '.cloud2.influxdata.com',
+  // split.io A/B flag
+  'streaming.split.io',
+  'telemetry.split.io',
+  'sdk.split.io',
+  // Google
+  // -ds.metric.gstatic.com are specifically exempted from reject, but it could use secondary proxy policy
+  '.metric.gstatic.com',
+  // Misc
+  'telemetry.1passwordservices.com',
+  'events.tableplus.com',
+  'telemetry.nextjs.org',
+  'telemetry.vercel.com',
+  'stats.setapp.com',
+  'stats.setapp.macpaw.dev',
+  '.app-analytics-services.com',
+  '.telemetry.services.yofi.ai',
+  '.cdn.pubnub.com',
+  '.data.debugbear.com',
+  '.cdn.applicationinsights.io',
+  '.applicationinsights.azure.com',
+  '.api.loganalytics.io',
+  '.bugly.qcloud.com',
+  // '.signalfx.com',
+  '.cdn.signalfx.com',
+  '.crash-reports.browser.yandex.net',
+  '.crashlytics2.l.google.com',
+  '.crashlyticsreports-pa.googleapis.com',
+  '.e.crashlytics.com',
+  '.events.backtrace.io',
+  '.events.split.io',
+  '.in.appcenter.ms',
+  '.loggly.com',
+  '.logz.io',
+  '.opentelemetry.io',
+  '.raygun.io', // dashboard lives at raygun.com
+  '.rum.cronitor.io',
+  '.settings.crashlytics.com',
+  '.sny.monosnap.com',
+  '.lr-ingest.com',
+  '.cdn.rollbar.com',
+  '.api.instabug.com',
+  '.ensighten.com'
+];
+
 export const PREDEFINED_WHITELIST = [
+  ...CRASHLYTICS_WHITELIST,
   '.localhost',
   '.local',
   '.localhost.localdomain',
diff --git a/Source/domainset/cdn.conf b/Source/domainset/cdn.conf
index c818d39f..aafa8c83 100644
--- a/Source/domainset/cdn.conf
+++ b/Source/domainset/cdn.conf
@@ -844,34 +844,6 @@ static.agilebits.com
 .cdn-lfs-us-1.huggingface.co
 .cdn-lfs.huggingface.co
 
-# >> Telemetry
-# I dont mind those specifically exempted telemetry, but it definitely could use secondary proxy policy
-telemetry.1passwordservices.com
-.in.applicationinsights.azure.com
-events.tableplus.com
-telemetry.nextjs.org
-telemetry.vercel.com
-stats.setapp.com
-stats.setapp.macpaw.dev
-.app-analytics-services.com
-.telemetry.services.yofi.ai
-# VSCode Telemetry, see https://sts.online.visualstudio.com/api/swagger/index.html
-sts.online.visualstudio.com
-# Sentry
-.ingest.sentry.io
-# bugsnag
-sessions.bugsnag.com
-# influxdata
-.cloud.influxdata.com
-.cloud1.influxdata.com
-.cloud2.influxdata.com
-# split.io A/B flag
-streaming.split.io
-telemetry.split.io
-sdk.split.io
-# Google
-# -ds.metric.gstatic.com are specifically exempted from reject, but it could use secondary proxy policy
-.metric.gstatic.com
 
 # >> Embed Tag / Widget
 2mdn.net