From 2799ebb8053fb59d653ea9ce59892f08294127b2 Mon Sep 17 00:00:00 2001 From: "Michael B. Sumulong" Date: Wed, 7 Apr 2021 15:58:04 -0400 Subject: [PATCH] Fix /etc/kvmd/{nginx,vnc}/ssl directory creation It appears that using quotes when doing brace expansion doesn't work as expected: [root@pikvm-zerow tmp]# mkdir -p -v "./etc/kvmd/{nginx,vnc}/ssl" mkdir: created directory './etc' mkdir: created directory './etc/kvmd' mkdir: created directory './etc/kvmd/{nginx,vnc}' mkdir: created directory './etc/kvmd/{nginx,vnc}/ssl' I believe the desired behavior is the following: [root@pikvm-zerow tmp]# mkdir -p -v "./etc/kvmd/"{nginx,vnc}"/ssl" mkdir: created directory './etc/kvmd/nginx' mkdir: created directory './etc/kvmd/nginx/ssl' mkdir: created directory './etc/kvmd/vnc' mkdir: created directory './etc/kvmd/vnc/ssl' I think the same change would also need to be made to https://github.com/pikvm/packages/blob/master/packages/kvmd/PKGBUILD which I can update if this is acceptable. This proposed change fixes this issue. --- PKGBUILD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PKGBUILD b/PKGBUILD index fe89de5b..0edf09a4 100644 --- a/PKGBUILD +++ b/PKGBUILD @@ -121,8 +121,8 @@ package_kvmd() { chmod 750 "$_cfg_default/os/sudoers" chmod 400 "$_cfg_default/os/sudoers"/* - mkdir -p "$pkgdir/etc/kvmd/{nginx,vnc}/ssl" - chmod 755 "$pkgdir/etc/kvmd/{nginx,vnc}/ssl" + mkdir -p "$pkgdir/etc/kvmd/"{nginx,vnc}"/ssl" + chmod 755 "$pkgdir/etc/kvmd/"{nginx,vnc}"/ssl" install -Dm444 -t "$pkgdir/etc/kvmd/nginx" "$_cfg_default/nginx"/*.conf chmod 644 "$pkgdir/etc/kvmd/nginx/nginx.conf"